# Instructions - Following Playwright test failed. - Explain why, be concise, respect Playwright best practices. - Provide a snippet of code with the fix, if possible. # Test info - Name: counters.spec.js >> Counters β€” HTML structure >> Phase 4.17 β€” comments modal + RPCs referenced - Location: tests/counters.spec.js:222:3 # Error details ``` Error: expect(received).toContain(expected) // indexOf Expected substring: "πŸ’¬ Comments" Received string: " Counters Β·
↻ New version available β€” tap to reload
⚠️ Inactive employees have allocated counters

πŸͺ Counters

All
β€”
Active
β€”
Pending
β€”
No Recce
β€”
Stale 90d
β€”
Closed
β€”
πŸ”
Counters
Β·

Counter

Identity
Address
Β·

New Counter

⚠ Possible existing counter
Β·
Β·
Primary address
Β·
Tax / Legal
Β·
Commercial
Β·
Notes
Β·
Β·

🏷 Clients

All
β€”
Active
β€”
Inactive
β€”
With users
β€”
πŸ”
Brand-side clients
Each client is a brand entity. Tap to expand and manage their users, invitations, role + scope. Users sign in at /recce-client/.
Β·

πŸ”” Notifications

Events that warrant a supervisor's attention: Recces flipped to Official, client Approved / Changes-requested responses, and other internal alerts. Emails to client_users are dispatched automatically.
Β·

πŸ“‹ Audit log

Every client_user action on the Recce Portal β€” magic-link logins, Recce viewer opens, accept / reject / approved_with_changes responses. IP + UA captured for forensics.
Retention: rows older than 180 days are auto-pruned nightly by the mail relay worker.
Β·
🏷 New client
Β·
βœ‰ Invite user
A magic-link email will be queued. Worker delivers within 30s.
Β·
πŸ’¬ Recce comments Β·
Β·
πŸ“Š Audit stats Β· last 7 days
⏳
Loading…
Β·
πŸ“Š Allocation Coverage
⏳
Loading…
Β·
⚑ Bulk Edit Counters
Apply a change to all counters matching the current list filter. Only blank fields are filled; existing values are never overwritten β€” except brand codes which are merged additively.
Scope: β€” counters selected by current filter
Merged with existing brands β€” never removes existing codes
Only applied to counters with no counter type set
Only applied to counters with no territory set
Only applied to counters with no channel set
Β·
πŸ”‘ Sessions
Β·

πŸ“Œ Multi-Recce Review

Counters with multiple Recces
Each group has 2+ Recces for the same counter + campaign (usually due to reassignment). Compare A vs B field-by-field, pick one as official, or use Supervisor Override to record the reason for your decision. The unchosen Recce is marked superseded. Tap \"View Counter β†’\" to see the full Recce history for any counter across all campaigns.
Β·

πŸ“₯ Counter Uploads

Awaiting supervisor review
Β·
⬆ Upload Counter List
Β·
πŸ€– AI Store Import
Β·
Paste any raw store list β€” WhatsApp forward, typed list, Excel copy-paste, anything. AI converts it, then matches to existing counters and enriches geo fields.
Converted β€”
Β·
⟳
Β·
Review each store β€” accept enrichment, edit, or skip
Β·
⇄ Bulk Reassign
Β·
πŸ‘₯ Allocate counter
Loading employees…
Β·
Add contact
Β·
Add address
Β·
Β· Β·
✨ AI Geo-fill
Β·
πŸ€– Ask AI for any counter
Counter
City
State
Β·
Review suggestions β€” uncheck any you disagree with
Β· " ``` # Test source ```ts 129 | expect(html).toContain('id="btn-allocate"'); 130 | expect(html).toContain('id="btn-uploads"'); 131 | expect(html).toContain('id="alloc-tiles"'); 132 | }); 133 | 134 | test('Phase 3 β€” Multi-Recce review screen + pick official present', () => { 135 | expect(html).toContain('id="s-multirecce"'); 136 | expect(html).toContain('id="btn-multirecce"'); 137 | expect(html).toContain('id="multirecce-badge"'); 138 | expect(html).toContain('pickOfficial('); 139 | expect(html).toContain('loadMultiRecce()'); 140 | expect(html).toContain('mark_official_recce'); 141 | expect(html).toContain('toggleMrg('); 142 | }); 143 | 144 | test('Phase 4.5 β€” clients admin screen + modals + RPCs referenced', () => { 145 | expect(html).toContain('id="s-clients"'); 146 | expect(html).toContain('id="btn-clients"'); 147 | expect(html).toContain('id="modal-newclient"'); 148 | expect(html).toContain('id="modal-invite"'); 149 | expect(html).toContain('openClients()'); 150 | expect(html).toContain('saveNewClient()'); 151 | expect(html).toContain('saveInvite()'); 152 | expect(html).toContain('admin_list_client_users'); 153 | expect(html).toContain('admin_list_invites'); 154 | expect(html).toContain('admin_revoke_client_user'); 155 | expect(html).toContain('admin_revoke_invite'); 156 | expect(html).toContain('client_admin_v'); 157 | }); 158 | 159 | test('Phase 4.6 β€” notifications screen + RPCs referenced', () => { 160 | expect(html).toContain('id="s-notify"'); 161 | expect(html).toContain('id="btn-notify"'); 162 | expect(html).toContain('id="notify-badge"'); 163 | expect(html).toContain('openNotify()'); 164 | expect(html).toContain('renderNotify'); 165 | expect(html).toContain('admin_list_notifications'); 166 | expect(html).toContain('admin_mark_notification_seen'); 167 | expect(html).toContain('πŸ”” Notifications'); 168 | }); 169 | 170 | test('Phase 4.7 β€” audit screen + RPCs referenced', () => { 171 | expect(html).toContain('id="s-audit"'); 172 | expect(html).toContain('id="btn-audit"'); 173 | expect(html).toContain('id="audit-badge"'); 174 | expect(html).toContain('openAudit()'); 175 | expect(html).toContain('renderAudit'); 176 | expect(html).toContain('admin_list_audit'); 177 | expect(html).toContain('client_audit_log'); 178 | expect(html).toContain('πŸ“‹ Audit log'); 179 | }); 180 | 181 | test('Phase 4.8 β€” sessions modal + RPCs referenced', () => { 182 | expect(html).toContain('id="modal-sessions"'); 183 | expect(html).toContain('openUserSessions('); 184 | expect(html).toContain('admin_list_sessions'); 185 | expect(html).toContain('admin_revoke_session'); 186 | expect(html).toContain('πŸ”‘ Sessions'); 187 | }); 188 | 189 | test('Phase 4.11 β€” risk chip styles + audit risk filter + suspicious_login meta', () => { 190 | expect(html).toContain('au-risk'); 191 | expect(html).toContain('au-risk.low'); 192 | expect(html).toContain('au-risk.medium'); 193 | expect(html).toContain('au-risk.high'); 194 | expect(html).toContain('id="audit-risk"'); 195 | expect(html).toContain("'suspicious_login'"); 196 | expect(html).toContain('Suspicious login'); 197 | }); 198 | 199 | test('Phase 4.12 β€” audit export + prune UI wired', () => { 200 | expect(html).toContain('id="audit-from"'); 201 | expect(html).toContain('id="audit-to"'); 202 | expect(html).toContain('exportAuditCsv()'); 203 | expect(html).toContain('pruneAuditNow()'); 204 | expect(html).toContain('admin_prune_audit'); 205 | expect(html).toContain('Retention: rows older than 180 days'); 206 | }); 207 | 208 | test('Phase 4.14 β€” audit stats modal + RPC referenced', () => { 209 | expect(html).toContain('id="modal-stats"'); 210 | expect(html).toContain('openAuditStats()'); 211 | expect(html).toContain('admin_audit_stats'); 212 | expect(html).toContain('πŸ“Š Stats'); 213 | expect(html).toContain('logins_by_risk'); 214 | expect(html).toContain('response_mix'); 215 | }); 216 | 217 | test('Phase 4.15 β€” supervisor_weekly_digest event meta wired', () => { 218 | expect(html).toContain("'supervisor_weekly_digest'"); 219 | expect(html).toContain('Weekly digest sent'); 220 | }); 221 | 222 | test('Phase 4.17 β€” comments modal + RPCs referenced', () => { 223 | expect(html).toContain('id="modal-comments"'); 224 | expect(html).toContain('openCommentsModal('); 225 | expect(html).toContain('postSupervisorComment'); 226 | expect(html).toContain('list_comments_for_sub'); 227 | expect(html).toContain('add_comment_as_supervisor'); 228 | expect(html).toContain('Recce comment'); > 229 | expect(html).toContain('πŸ’¬ Comments'); | ^ Error: expect(received).toContain(expected) // indexOf 230 | }); 231 | 232 | test('Phase 4.18 β€” Sessions modal references pending-invite admin RPC', () => { 233 | expect(html).toContain('adminRevokePendingInvite'); 234 | expect(html).toContain('admin_revoke_invite'); 235 | expect(html).toContain('admin_list_invites'); 236 | expect(html).toContain('p_client_user_id: _sessionsForUser'); 237 | expect(html).toContain('Pending invites'); 238 | }); 239 | 240 | test('Phase 4.0a β€” signed-URL viewer wired (no direct window.open on view_url)', () => { 241 | expect(html).toContain('openSignedRecceView('); 242 | expect(html).toContain('/recce-view-proxy/sign'); 243 | expect(html).not.toMatch(/window\.open\(['"][^'"]*\$\{[^}]*view_url[^}]*\}['"]/); 244 | }); 245 | }); 246 | 247 | // ────────────────────────────────────────────────────────── 248 | // AUTH 249 | // ────────────────────────────────────────────────────────── 250 | test.describe('Counters β€” Auth', () => { 251 | test('no session β†’ redirects to /hub/?next=/counters/', async ({ page }) => { 252 | await page.goto(BASE); 253 | await page.waitForURL(/\/hub\//, { timeout: 4000 }).catch(() => {}); 254 | const url = page.url(); 255 | const onHubWithNext = url.includes('/hub/') && url.includes('next=') && url.includes('counters'); 256 | const stillOnCounters = !await page.evaluate(() => !!localStorage.getItem('lm360-session')); 257 | expect(onHubWithNext || stillOnCounters).toBeTruthy(); 258 | }); 259 | 260 | test('supervisor (harish) sees + New button', async ({ page }) => { 261 | await injectSession(page, 'harish', 'Harish Kumar Lal'); 262 | await page.goto(BASE); 263 | await page.waitForTimeout(600); 264 | await expect(page.locator('#btn-new')).toBeVisible(); 265 | await expect(page.locator('#user-pill')).toContainText('SUPERVISOR'); 266 | }); 267 | 268 | test('non-supervisor (mukesh) hides + New + Edit', async ({ page }) => { 269 | await injectSession(page, 'mukesh', 'Mukesh'); 270 | await page.goto(BASE); 271 | await page.waitForTimeout(600); 272 | await expect(page.locator('#btn-new')).toBeHidden(); 273 | await expect(page.locator('#user-pill')).not.toContainText('SUPERVISOR'); 274 | }); 275 | 276 | test('rakesh is a supervisor', async ({ page }) => { 277 | await injectSession(page, 'rakesh', 'Rakesh'); 278 | await page.goto(BASE); 279 | await page.waitForTimeout(600); 280 | await expect(page.locator('#btn-new')).toBeVisible(); 281 | await expect(page.locator('#user-pill')).toContainText('SUPERVISOR'); 282 | }); 283 | }); 284 | 285 | // ────────────────────────────────────────────────────────── 286 | // HUB REGISTRATION 287 | // ────────────────────────────────────────────────────────── 288 | test.describe('Counters β€” Hub registration', () => { 289 | test('PWA row in hub.pwa_registry with grants for harish, pramod, rakesh', async () => { 290 | const ctx = await request.newContext(); 291 | const reg = await ctx.get(`${DB}/pwa_registry?id=eq.counters&select=id,label,access_group,is_live`, { 292 | headers: { 'Accept-Profile': 'hub' }, 293 | }); 294 | expect(reg.status()).toBe(200); 295 | const rows = await reg.json(); 296 | expect(rows).toHaveLength(1); 297 | expect(rows[0].access_group).toBe('counters'); 298 | expect(rows[0].is_live).toBe(true); 299 | 300 | const acc = await ctx.get(`${DB}/employee_pwa_access?access_group=eq.counters&select=employee_id`, { 301 | headers: { 'Accept-Profile': 'hub' }, 302 | }); 303 | const empIds = (await acc.json()).map(r => r.employee_id).sort(); 304 | expect(empIds).toEqual(expect.arrayContaining(['harish', 'pramod', 'rakesh'])); 305 | await ctx.dispose(); 306 | }); 307 | }); 308 | 309 | // ────────────────────────────────────────────────────────── 310 | // END-TO-END β€” create, edit, contact, delete 311 | // ────────────────────────────────────────────────────────── 312 | test.describe('Counters β€” E2E supervisor flow', () => { 313 | test('create counter β†’ detail β†’ add contact β†’ search β†’ cleanup', async ({ page }) => { 314 | await injectSession(page); 315 | await page.goto(BASE); 316 | await page.waitForTimeout(500); 317 | 318 | // Create 319 | await page.click('#btn-new'); 320 | await page.waitForTimeout(150); 321 | const stamp = Date.now().toString(36).slice(-6); 322 | const name = `Playwright Counter ${stamp}`; 323 | await page.fill('#f-display_name', name); 324 | await page.fill('#f-address_line1', '99 Test Road'); 325 | await page.fill('#f-city', 'Mohali'); 326 | await page.fill('#f-pincode', '160055'); 327 | await page.fill('#brand-inp', 'HP'); await page.press('#brand-inp', 'Enter'); 328 | await page.fill('#brand-inp', 'LENOVO'); await page.press('#brand-inp', 'Enter'); 329 | await page.click('#btn-save'); ```